Remove the isFinal flag from the Metric interface #86
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #82 by removing the
isFinal
flag from theMetric
interface.The primary implication of this change is now when calling any of the metric functions with the
reportAllChanges
argument set totrue
, the callback will only be invoked if the metric value changes—i.e. the callback won't be invoked when the page is backgrounded or unloading, nor (in the case ofgetLCP()
) will the callback be invoked after user input.Prior to this change a callback could be invoked without its value changing, but the
isFinal
flag would flip fromfalse
totrue
.cc: @addyosmani as this will affect the Web Vitals Extension.