-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Add WordPress guidance for iframes lazy-loading #3698
Conversation
Add paragraph with bulk update solution for Wordpress users
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
Deploy preview for web-dev-staging ready! Built with commit 7353107 |
@addyosmani are you ok reviewing this change? |
See #3705 for an explanation on why this is failing. I think rebasing or pulling from master will fix it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a wonderful little addition, thanks @JayHoltslander (you seem to have written technical docs before)
I'm going to get someone in to verify that we recommend this WP practice
Co-authored-by: Kayce Basques <kayce@google.com>
Co-authored-by: Kayce Basques <kayce@google.com>
Co-authored-by: Kayce Basques <kayce@google.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Accept suggestions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Someone pointed out to me that we're not formatting WordPress correctly
(Tip: Use the Add suggestion to batch feature to batch-accept all of these small edits as one commit)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly LGTM. I added a reference to the WP core ticket where this is being worked on and updated the code snippet to cover for once that is built into core, to avoid this snippet from conflicting.
Similarly, change mostly LGTM. |
Co-authored-by: Felix Arntz <felixarntz@users.noreply.github.com>
Add paragraph with bulk update solution for Wordpress users
next step: @kaycebasques to verify that we support this approach (pinged relevant people on 8/25)