Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

State of CSS 2024 Survey #931

Merged
merged 1 commit into from
Dec 4, 2024
Merged

State of CSS 2024 Survey #931

merged 1 commit into from
Dec 4, 2024

Conversation

KyleJu
Copy link
Collaborator

@KyleJu KyleJu commented Nov 23, 2024

A part of #764. Add a global bookmark for state of CSS surveys.

There are 20 features in the State of CSS 2024 survey. It will show the top 10 developer needs on the bookmark. Note that

  • scrollbar styling is represented by three features through name:scrollbar
  • browser_support is not a feature. Instead scoping is shown

@KyleJu KyleJu requested a review from atopal November 23, 2024 01:17
@KyleJu
Copy link
Collaborator Author

KyleJu commented Nov 23, 2024

cc @jcscottiii

@atopal
Copy link
Collaborator

atopal commented Nov 24, 2024

Thank you Kyle, I think we should limit the top developer needs to the top 10 for now, supporting numbers get very low beyond top 5 already.

Here are some thoughts:

Browser support is not a feature and we can skip that, and include scoping instead, which is https://webstatus.dev/features/scope?q=scope

@KyleJu
Copy link
Collaborator Author

KyleJu commented Nov 25, 2024

Thank you Kyle, I think we should limit the top developer needs to the top 10 for now, supporting numbers get very low beyond top 5 already.

Here are some thoughts:

Browser support is not a feature and we can skip that, and include scoping instead, which is https://webstatus.dev/features/scope?q=scope

Addressed. Now it shows 12 results in total, including 3 from scrollball

@atopal
Copy link
Collaborator

atopal commented Nov 26, 2024

Thank you Kyle!

In the list transitions (CSS) is not the same as view transitions, can we change that to this one?

@KyleJu
Copy link
Collaborator Author

KyleJu commented Nov 26, 2024

Thank you Kyle!

In the list transitions (CSS) is not the same as view transitions, can we change that to this one?

Corrected. I also saw your additional comment, and I plan to address them in follow-up PRs.

Is this PR ready to be merged or should we wait for all survey results?

@atopal
Copy link
Collaborator

atopal commented Nov 26, 2024

Sorry Kyle, for some reason I thought this PR was only about the list of features, that's why added the comment to #764 764 We don't have to wait for the other survey results to merge this, but we do need the explainer text above the list before we can show this to users.

@KyleJu
Copy link
Collaborator Author

KyleJu commented Nov 26, 2024

Sorry Kyle, for some reason I thought this PR was only about the list of features, that's why added the comment to #764 764 We don't have to wait for the other survey results to merge this, but we do need the explainer text above the list before we can show this to users.

Sounds good. Looks like I need a separate PR for the UI changes first. This PR will be merged after

Copy link
Collaborator

@atopal atopal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@KyleJu
Copy link
Collaborator Author

KyleJu commented Dec 4, 2024

@atopal after incorporating the UI changes. How does this look?

Screenshot 2024-12-03 4 04 14 PM

@KyleJu KyleJu requested a review from jcscottiii December 4, 2024 00:46
@KyleJu KyleJu added this pull request to the merge queue Dec 4, 2024
Merged via the queue into main with commit 7dfd93f Dec 4, 2024
6 checks passed
@KyleJu KyleJu deleted the css-survey branch December 4, 2024 20:46
@atopal
Copy link
Collaborator

atopal commented Dec 4, 2024

@atopal after incorporating the UI changes. How does this look?

Screenshot 2024-12-03 4 04 14 PM

Thank you Kyle! A few nits: Can we make the link to the survey a clickable link? If not, let's remove the link. The contrast seems a bit too low, can we go darker on the color? And finally, it would be good to leave a bit of a margin between the text and the "Percentage of features mapped" text.

Again, thank you! This is great!

@KyleJu KyleJu mentioned this pull request Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants