Fix Usage percentage display #941
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcscottiii
reviewed
Nov 26, 2024
| @@ -157,8 +157,15 @@ const renderChromiumUsage: CellRenderer = ( | |||
| _options, | |||
| ) => { | |||
| if (feature.usage?.chromium?.daily && feature.usage.chromium.daily > 0) { | |||
| // Format to display percentage with single decimal e.g. 0.8371 -> 83.7%. | |||
| return html`${(feature.usage.chromium.daily * 100).toFixed(1)}%`; | |||
There was a problem hiding this comment.
Apologies for my earlier confusing comment internally. It is still a ratio between 0 and 1 from the backend. I meant to say the presentation layer here should present a percentage at most 100%. (whereas right now, we see values way above 100%). Once we fix the data upstream, the ratios will go back to being between 0 and 1 (and we can continue with the existing logic to make it a percentage).
jcscottiii
reviewed
Nov 26, 2024
| return html`${(feature.usage.chromium.daily * 100).toFixed(1)}%`; | ||
| // If the feature has some usage, but the usage is less than 0.1%, | ||
| // display it that way. | ||
| if (feature.usage.chromium.daily < 0.01) { |
There was a problem hiding this comment.
I do like this logic for very small numbers. Can you adjust it according to my comment above about how the number is indeed a ratio between 0 and 1.
jcscottiii
reviewed
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chromium usage is currently being displayed with inflated numbers (x100). This change updates the usage display to fix this bug.
Additionally, 0% usage values are explicitly displayed as "0.0%" rather than "N/A", and features with very small but non-zero usage are displayed as "<0.1%".