Fix CacheExpiration / IndexedDB OpenCursor for Edge

[josephliccini]

Prior to filing a PR, please:

• open an issue to discuss your proposed change.
• ensure that gulp lint test passes locally.

R: @jeffposnick @philipwalton

Fixes #1509

Edge Browser does not support undefined arguments being passed into openCursor(...)

I handle each case for the arguments to openCursor(...)

See https://developer.mozilla.org/en-US/docs/Web/API/IDBObjectStore/openCursor for more information on the API itself.

This will fix the CacheExpiration logic in Edge Browsers that depend on openCursor(...) in the expiration entry lookup process.

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

---

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

[josephliccini]

Things seem to be working in browsers, but the Mock library used doesn't like null. I filed an issue on them, and am also discussing with Edge best approach here with undefineds

[philipwalton]

I'm fine with these changes. In fact, the version of the DBWrapper code that we were discussing releasing separately has these exact changes (since I noticed this was failing in IE), and I was planning to upstream them.

As for the mock library, did that issue get addressed? Can you link to it? I think we're already using a fork of that anyway, so we could potentially fix it in the fork if there's no response from the maintainer.

[josephliccini]

Hi @philipwalton !

Thanks for taking a look at this!

Here's the mock library issue: dhoulb/shelving-mock-indexeddb#6

I can submit a CR to them or to your fork with the fix.

[philipwalton]

If you submit a PR to https://github.com/philipwalton/shelving-mock-indexeddb I'll merge it while we wait on the master repo.

[josephliccini]

@philipwalton here it is: philipwalton/shelving-mock-indexeddb#2

Thanks!

[philipwalton]

Thanks @josephliccini. The mock library has been updated, so these tests should hopefully pass now. Can you make sure to sign the CLA (as described in #1510 (comment)) so we can merge this?

[coveralls]

Coverage increased (+0.02%) to 86.532% when pulling 2fb80c9 on josephliccini:josephliccini/edge-indexeddb into d95348b on GoogleChrome:master.

[josephliccini]

Awesome, will do! Just checking internally if there's any extra process for CLA I need to be aware of.

[josephliccini]

Just working through the internal process here, hopefully it won't take too much longer. Thanks for being patient

[josephliccini]

I signed it!

[googlebot]

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

[googlebot]

CLAs look good, thanks!

[josephliccini]

Turns out it's OK for me to just sign the individual CLA. (I double checked, it took some time).

Should be good to go!

[jeffposnick]

Thanks again, @josephliccini! We'll get this into the next Workbox release.