-
Notifications
You must be signed in to change notification settings - Fork 831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable gzip + cache-control on CDN #1523
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweet! Great to have this working.
public: true, | ||
resumable: false, | ||
metadata: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This double metadata
is weird, but required...
PR-Bot Size PluginChanged File SizesNo file sizes have changed. New FilesNo new files have been added. All File SizesView Table
Workbox Aggregate Size Plugin9.57KB gzip'ed (64% of limit) |
Looks like that (at least) the cache-control part of this PR didn't work properly:
|
#1539 will hopefully do the trick. (I swore that code worked for me when testing against another Cloud Storage bucket...) |
R: @philipwalton
Fixes #1412
It took a little bit of experimentation with a test project, but based on those results, this code is sufficient to enable both
gzip
compression and theCache-Control
header.(Let's obviously pay close attention to the CDN uploads right after our next release.)