Ensure all private modules are exported correctly #2050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffposnick
suggested changes
May 1, 2019
There was a problem hiding this comment.
As per https://travis-ci.org/GoogleChrome/workbox/builds/526673251#L2763-L2775, I think there's some cleanup needed at
|
Ahh, yes, so given that |
philipwalton
force-pushed
the
private-exports
branch
from
a13d481
to
f213c7b
Compare
PR-Bot Size PluginChanged File Sizes
New FilesNo new files have been added. All File SizesView Table
Workbox Aggregate Size Plugin8.96KB gzip'ed (60% of limit) |
jeffposnick
approved these changes
May 1, 2019
This was referenced Jan 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R: @jeffposnick
Fixes #2049, fixes #2045.
This PR ensures all files in
_privatedirectory are exported via the top level_private.mjsfile. It also removes exports that are no longer needed.The
quota.mjsfile exported two separate symbols, so it initially failed the new private-exports test, but since it's not used outside ofworkbox-coreit was fine to just move it to theutilsfolder instead.