Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ${pathnameAndSearch} info within _match() logging #2071

Merged
merged 1 commit into from
Jun 10, 2019

Conversation

nuragic
Copy link
Contributor

@nuragic nuragic commented Jun 6, 2019

Given that I struggled to find these console logs because I was using console filtering (which is a quite common practice), I think it would be nice to add the ${pathnameAndSearch} within the _match() logging, in order to discover issues like this more quickly: facebook/create-react-app#7176

Cc @jeffposnick

Thanks!

@jeffposnick jeffposnick self-requested a review June 6, 2019 17:16
Copy link
Contributor

@jeffposnick jeffposnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @nuragic! There are some linting errors due to line lengths—could you break things up, matching the existing style, so that lines aren't more than 80 characters?

/home/travis/build/GoogleChrome/workbox/packages/workbox-routing/NavigationRoute.mjs
   91:1  error  Line 91 exceeds the maximum line length of 80   max-len
  100:1  error  Line 100 exceeds the maximum line length of 80  max-len
  106:1  error  Line 106 exceeds the maximum line length of 80  max-len

@nuragic
Copy link
Contributor Author

nuragic commented Jun 6, 2019

Ups sorry! I'll fix that.

@nuragic nuragic force-pushed the blacklist-log-url-info branch from 09b99a0 to 4bd2c80 Compare June 7, 2019 08:25
@nuragic
Copy link
Contributor Author

nuragic commented Jun 7, 2019

Fixed. What do you think about using e.g. https://github.com/declandewet/common-tags#oneline to avoid the + concatenations? 😄

@jeffposnick
Copy link
Contributor

We deliberately avoid using external dependencies inside of the code that runs in the service worker and/or in the window context.

(We do use commen-tags in our node-based tools, however.)

@jeffposnick jeffposnick self-requested a review June 7, 2019 20:13
@nuragic
Copy link
Contributor Author

nuragic commented Jun 7, 2019

Oh, ok it's great that you don't have external deps! 👌

Copy link
Contributor

@jeffposnick jeffposnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(The CI servers are now being cranky about unrelated issues.)

@jeffposnick jeffposnick merged commit b10f13f into GoogleChrome:master Jun 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants