Use a .js extension when generating a default swDest

[jeffposnick]

R: @philipwalton

Our webpack plugin will generate a default output service worker filename (swDest) using the basename of the required swSrc parameter when swDest isn't explicitly provided.

If the swSrc file is TypeScript, then chances are it has a .ts extension, and we don't want that to be used as the extension in swDest. (Ideally, the developer will have set up ts-loader to automatically compile the TypeScript file in their build process, so the output will be JavaScript.)

This change forces the .js file extension whenever we're calculating a default swDest value.

[philipwalton]

I think this is fine.

One concern I have is what to do if the user explicitly doesn't want a .js extension. E.g. maybe they're using app.sw or something like that.

[jeffposnick]

They could set swDest: 'app.sw' and get the behavior you describe. This change only applies when there's no swDest and we have to infer it based on the swSrc value.

[workbox-pr-bot]

PR-Bot Size Plugin

Changed File Sizes

No file sizes have changed.

New Files

No new files have been added.

All File Sizes

View Table

File	Before	After	Change	GZipped
packages/workbox-background-sync/build/workbox-background-sync.prod.js	3.86 KB	3.86 KB	0%	1.59 KB
packages/workbox-broadcast-update/build/workbox-broadcast-update.prod.js	1.92 KB	1.92 KB	0%	959 B
packages/workbox-build/build/_types.js	41 B	41 B	0%	61 B
packages/workbox-build/build/index.js	3.30 KB	3.30 KB	0%	1.31 KB
packages/workbox-cacheable-response/build/workbox-cacheable-response.prod.js	594 B	594 B	0%	354 B
packages/workbox-cli/build/app.js	4.15 KB	4.15 KB	0%	1.64 KB
packages/workbox-cli/build/bin.js	940 B	940 B	0%	502 B
packages/workbox-core/build/workbox-core.prod.js	5.94 KB	5.94 KB	0%	2.46 KB
packages/workbox-expiration/build/workbox-expiration.prod.js	2.94 KB	2.94 KB	0%	1.27 KB
packages/workbox-google-analytics/build/workbox-offline-ga.prod.js	1.95 KB	1.95 KB	0%	913 B
packages/workbox-navigation-preload/build/workbox-navigation-preload.prod.js	660 B	660 B	0%	324 B
packages/workbox-precaching/build/workbox-precaching.prod.js	4.25 KB	4.25 KB	0%	1.70 KB
packages/workbox-range-requests/build/workbox-range-requests.prod.js	1.57 KB	1.57 KB	0%	797 B
packages/workbox-routing/build/workbox-routing.prod.js	3.41 KB	3.41 KB	0%	1.47 KB
packages/workbox-strategies/build/workbox-strategies.prod.js	4.78 KB	4.78 KB	0%	1.20 KB
packages/workbox-streams/build/workbox-streams.prod.js	1.46 KB	1.46 KB	0%	720 B
packages/workbox-sw/build/workbox-sw.js	1.34 KB	1.34 KB	0%	747 B
packages/workbox-webpack-plugin/build/generate-sw.js	3.13 KB	3.13 KB	0%	1.22 KB
packages/workbox-webpack-plugin/build/index.js	349 B	349 B	0%	255 B
packages/workbox-webpack-plugin/build/inject-manifest.js	4.67 KB	4.67 KB	0%	1.59 KB
packages/workbox-window/build/workbox-window.dev.umd.js	31.88 KB	31.88 KB	0%	8.10 KB
packages/workbox-window/build/workbox-window.prod.umd.js	4.46 KB	4.46 KB	0%	1.84 KB

Workbox Aggregate Size Plugin

3.49KB gzip'ed (23% of limit)
7.8KB uncompressed

[philipwalton]

Ahh, gotcha, SGTM!