Honor subdirectory prefixes as part of swDest #2140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffposnick
commented
Jul 23, 2019
| @@ -1091,14 +1091,48 @@ describe(`[workbox-webpack-plugin] GenerateSW (End to End)`, function() { | |||
| } | |||
| }); | |||
| }); | |||
|
|
|||
| it(`should support using a swDest that includes a subdirectory`, function(done) { | |||
There was a problem hiding this comment.
FYI—GitHub auto-hides this diff by default, but here's the new test case.
philipwalton
approved these changes
Jul 23, 2019
PR-Bot Size PluginChanged File Sizes
New FilesNo new files have been added. All File SizesView Table
Workbox Aggregate Size Plugin3.49KB gzip'ed (23% of limit) |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R: @philipwalton
CC: @derekdowling
Fixes #2138
In the course of fixing the bug that prevented relative
swDestpath prefixes from working, I took the opportunity to normalize all of ourpathusage in thenodetools toupath. That saved some effort in adding in some Windows-specific logic to this PR, and making the change universally seemed like the safest thing to do in the long run, as we've already made some piecemeal changes.