importScriptsViaChunks checks for .js extension #2164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR-Bot Size PluginChanged File SizesNo file sizes have changed. New FilesNo new files have been added. All File SizesView Table
Workbox Aggregate Size Plugin3.5KB gzip'ed (23% of limit) |
philipwalton
approved these changes
Aug 2, 2019
| @@ -17,7 +19,10 @@ module.exports = (compilation, chunkNames) => { | |||
| const chunk = chunks.find((chunk) => chunk.names.includes(chunkName)); | |||
| if (chunk) { | |||
| for (const file of chunk.files) { | |||
| scriptFiles.add(resolveWebpackURL(publicPath, file)); | |||
| // See https://github.com/GoogleChrome/workbox/issues/2161 | |||
| if (upath.extname(file) === '.js') { | |||
There was a problem hiding this comment.
I doubt non-js extensions ever happen with webpack chunks, but I wonder if we want to be a bit more forgiving here and accept things like .mjs. What do you think?
There was a problem hiding this comment.
See my comment in the PR description 😄
(
importScripts()will never play nicely with ES modules, so.mjsis a non-issue.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R: @philipwalton
Fixes #2161
I think this is a reasonable restriction, and allowing developers to customize things to allow for non-
.jsextensions seems like overkill.(
importScripts()will never play nicely with ES modules, so.mjsis a non-issue.)