Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R: @jeffposnick
Fixes #2171, fixes #2180.
The were several places in the existing
workbox-routing
code where our type definitions claim to only acceptHandlerCallback
, but in reality we acceptHandler | HandlerCallback
.Instead of adding both types everywhere, I opted to renamed the old
Handler
type toHandlerObject
, and then re-addHandler
asHandlerObject | HandlerCallback
(since that's what's exposed to most public APIs).The end result was about the same about of code/changes, but I think calling it
HandlerObject
(orRouteHandlerObject
in the core) is a bit more explicit.