Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a RouteHandlerObject type #2183

Merged
merged 1 commit into from
Aug 14, 2019
Merged

Add a RouteHandlerObject type #2183

merged 1 commit into from
Aug 14, 2019

Conversation

philipwalton
Copy link
Member

R: @jeffposnick

Fixes #2171, fixes #2180.

The were several places in the existing workbox-routing code where our type definitions claim to only accept HandlerCallback, but in reality we accept Handler | HandlerCallback.

Instead of adding both types everywhere, I opted to renamed the old Handler type to HandlerObject, and then re-add Handler as HandlerObject | HandlerCallback (since that's what's exposed to most public APIs).

The end result was about the same about of code/changes, but I think calling it HandlerObject (or RouteHandlerObject in the core) is a bit more explicit.

@workbox-pr-bot
Copy link
Collaborator

PR-Bot Size Plugin

Changed File Sizes

No file sizes have changed.

New Files

No new files have been added.

All File Sizes

View Table
File Before After Change GZipped
packages/workbox-background-sync/build/workbox-background-sync.prod.js 3.86 KB 3.86 KB 0% 1.60 KB
packages/workbox-broadcast-update/build/workbox-broadcast-update.prod.js 1.92 KB 1.92 KB 0% 959 B
packages/workbox-build/build/_types.js 41 B 41 B 0% 61 B
packages/workbox-build/build/index.js 3.30 KB 3.30 KB 0% 1.31 KB
packages/workbox-cacheable-response/build/workbox-cacheable-response.prod.js 594 B 594 B 0% 354 B
packages/workbox-cli/build/app.js 4.16 KB 4.16 KB 0% 1.64 KB
packages/workbox-cli/build/bin.js 940 B 940 B 0% 502 B
packages/workbox-core/build/workbox-core.prod.js 5.94 KB 5.94 KB 0% 2.46 KB
packages/workbox-expiration/build/workbox-expiration.prod.js 2.94 KB 2.94 KB 0% 1.27 KB
packages/workbox-google-analytics/build/workbox-offline-ga.prod.js 1.95 KB 1.95 KB 0% 912 B
packages/workbox-navigation-preload/build/workbox-navigation-preload.prod.js 660 B 660 B 0% 323 B
packages/workbox-precaching/build/workbox-precaching.prod.js 4.99 KB 4.99 KB 0% 1.94 KB
packages/workbox-range-requests/build/workbox-range-requests.prod.js 1.57 KB 1.57 KB 0% 797 B
packages/workbox-routing/build/workbox-routing.prod.js 3.09 KB 3.09 KB 0% 1.36 KB
packages/workbox-strategies/build/workbox-strategies.prod.js 4.10 KB 4.10 KB 0% 1.13 KB
packages/workbox-streams/build/workbox-streams.prod.js 1.46 KB 1.46 KB 0% 721 B
packages/workbox-sw/build/workbox-sw.js 1.34 KB 1.34 KB 0% 748 B
packages/workbox-webpack-plugin/build/generate-sw.js 4.24 KB 4.24 KB 0% 1.62 KB
packages/workbox-webpack-plugin/build/index.js 349 B 349 B 0% 255 B
packages/workbox-webpack-plugin/build/inject-manifest.js 5.12 KB 5.12 KB 0% 1.77 KB
packages/workbox-window/build/workbox-window.dev.umd.js 41.34 KB 41.34 KB 0% 9.09 KB
packages/workbox-window/build/workbox-window.prod.umd.js 4.65 KB 4.65 KB 0% 1.91 KB

Workbox Aggregate Size Plugin

3.5KB gzip'ed (23% of limit)
7.79KB uncompressed

Copy link
Contributor

@jeffposnick jeffposnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jeffposnick jeffposnick merged commit a068fa6 into master Aug 14, 2019
@jeffposnick jeffposnick deleted the handler-type-fix branch August 14, 2019 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants