Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R: @philipwalton
This is a general refactor of the directory structure and inheritance for our
joi
-based options validation. In the process, I loosened one of the restrictions so that developers usingworkbox-build
'sgenerateSW
mode could useruntimeCaching
could be used without precaching (fixes #2078).The PR got pretty large, given all the files moved around, so I'm going to submit a follow-up PR that deals with JSDocs for our options, which I think is ultimately a more sustainable documentation setup than what we currently use. (C.f. https://github.com/google/WebFundamentals/tree/master/src/content/en/tools/workbox/_shared/config)