Add copyResponse and more granular stream detects #2193
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R: @jeffposnick
Fixes #2023
This PR replaces #2128 and implements the resolution from the discussion there. It adds two new, more granular feature detects for streams to
workbox-core
:canConstructReadableStream()
canConstructResponseFromBodyStream()
And these features are used by other stream-related code to detect support.
Also, based on the feature request proposed in #2023, it adds a
copyResponse()
function that allows you to copy a response and modify any of the values settable via theResponseInit
object (headers
,status
,statusText
).The API I've landed on in this PR (totally open to suggestions though) is a function that takes a response and a
modifier()
function, here's an example (you can also see other examples in the test file):In addition, as currently implement, the
modifier()
function is optional, and if not passed then no modifications are made. This is equivalent to the oldcleanRedirect()
function that this PR removes. (I'm not sure if it's weird to have themodifier()
function be optional. If you think it is, I can make it required and just have it be a no-op in the redirect case.)