Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add redundant to WorkboxLifecycleEventMap #2200

Merged
merged 1 commit into from
Aug 23, 2019

Conversation

azizhk
Copy link
Contributor

@azizhk azizhk commented Aug 23, 2019

R: @jeffposnick @philipwalton
Fixes #2199

Should I add externalredundant as well? I don't think that exists right?

Copy link
Member

@philipwalton philipwalton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@philipwalton philipwalton merged commit ae80e39 into GoogleChrome:master Aug 23, 2019
@philipwalton
Copy link
Member

philipwalton commented Aug 23, 2019

Should I add externalredundant as well? I don't think that exists right?

I think it's possible that it could be emitted by a Workbox (given the right circumstances), but it's not an event we want to promote people listening to, so we don't document it and I don't think we need to add typings for it either.

In general, as soon as there's any external* events fired, that's the point at which the user should probably refresh the page, as it usually means the version of the page they're running is out of date and things may break.

@azizhk azizhk deleted the add_redundant branch August 26, 2019 08:00
@azizhk
Copy link
Contributor Author

azizhk commented Aug 28, 2019

In general, as soon as there's any external* events fired, that's the point at which the user should probably refresh the page"
So I don't expect the user to reload, I do window.location.reload() explicitly.

@philipwalton In the example that I have shared, before triggering skipWaiting for a SW which has multiple clients connected, I double check with the user that I will be reloading multiple tabs and he might lose data.

Screenshot 2019-08-28 at 2 21 30 PM

So similarly, in that case, I would like to have "externalredundant" event getting triggered to reload the page.

But I'll come back to this requirement based on the answer to #2199 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"redundant" event getting triggered.
2 participants