Add a check to wait for the resulting client ID #2210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipwalton
force-pushed
the
resulting-client
branch
2 times, most recently
from
1bf0e19
to
515b669
Compare
|
For some reason the I think let's merge a few of the other open |
philipwalton
force-pushed
the
resulting-client
branch
from
515b669
to
8f5d621
Compare
jeffposnick
reviewed
Sep 5, 2019
| const reg = await wb.register(); | ||
| const updatefoundPromise = new Promise((resolve) => { |
There was a problem hiding this comment.
This test from yesterday needed a bit more cleaning up, as there was a race condition in which the updatefound listener might not have been registered in time to catch the update. Registering the listener early and then waiting later on for the promise resolution should fix that.
philipwalton
force-pushed
the
resulting-client
branch
2 times, most recently
from
8a2c728
to
ba96115
Compare
philipwalton
force-pushed
the
resulting-client
branch
from
ba96115
to
a78252c
Compare
|
Updated to skip the failing test in Safari. @jeffposnick can you PTAL. |
PR-Bot Size PluginChanged File Sizes
New FilesNo new files have been added. All File SizesView Table
Workbox Aggregate Size Plugin3.51KB gzip'ed (23% of limit) |
jeffposnick
approved these changes
Sep 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R: @jeffposnick
Fixes #2203, fixes #2204
To fix #2203, this PR adds a
resultingClientExists()method that accepts aresultingClientIdvalue and awaits the existence of the client. It can also resolve toundefinedin one of two conditions:resultingClientIdvalue isundefined(as will happen in a browser that doesn't support it).Then, to fix #2204, in the
BroadcastCacheUpdateclass, I've added atimeoutthat waits for an additional 3.5 seconds (explanation here) in Safari or if theresultingClientExists()function doesn't find a matching client. (Note: I've added a TODO to remove the Safari check once this bug has been released.)I've also updated the integrations to be more comprehensive. Previously there was only a test for resource requests, so I've added: