Don't double-prepend the output dir #2223
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R: @philipwalton
I came across this issue when manually testing v5 using a config like:
Prior to this change, the code would attempt to write the generated service worker to
public/public/service-worker.js
, because the filenames returned from Rollup would already include thepublic/
prefix.(The original test unfortunately did not catch this because the wrong assumption was made when stubbing out Rollup's behavior.)