Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New precache helper functions + removal of createHandlerForURL #2254

Merged
merged 3 commits into from
Oct 16, 2019

Conversation

jeffposnick
Copy link
Contributor

R: @philipwalton

Fixes #2249

Exposes three new functions:

  • async function matchPrecache(request: string|Request): Promise<Response|null>
  • function createHandler(fallbackToNetwork = true): RouteHandlerCallback
  • function createHandlerBoundToURL(url: string, fallbackToNetwork = true): RouteHandlerCallback

createHandlerBoundToURL replaces createHandlerForURL, and serves the same purpose.

@coveralls
Copy link

coveralls commented Oct 15, 2019

Coverage Status

Coverage remained the same at 79.409% when pulling ef3a1c7 on new-precache-methods into f23924a on master.

Copy link
Contributor Author

@jeffposnick jeffposnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PTAL.

Copy link
Member

@philipwalton philipwalton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a few non-blocking questions.

packages/workbox-precaching/src/PrecacheController.ts Outdated Show resolved Hide resolved
packages/workbox-precaching/src/index.ts Outdated Show resolved Hide resolved
@workbox-pr-bot
Copy link
Collaborator

PR-Bot Size Plugin

Changed File Sizes

File Before After Change GZipped
packages/workbox-precaching/build/workbox-precaching.prod.js 4.95 KB 5.31 KB +7% 2.00 KB

New Files

No new files have been added.

All File Sizes

View Table
File Before After Change GZipped
packages/workbox-background-sync/build/workbox-background-sync.prod.js 3.87 KB 3.87 KB 0% 1.60 KB
packages/workbox-broadcast-update/build/workbox-broadcast-update.prod.js 1.34 KB 1.34 KB 0% 738 B
packages/workbox-build/build/_types.js 41 B 41 B 0% 61 B
packages/workbox-build/build/generate-sw.js 2.75 KB 2.75 KB 0% 1.23 KB
packages/workbox-build/build/get-manifest.js 1.60 KB 1.60 KB 0% 779 B
packages/workbox-build/build/index.js 613 B 613 B 0% 344 B
packages/workbox-build/build/inject-manifest.js 4.93 KB 4.93 KB 0% 1.90 KB
packages/workbox-cacheable-response/build/workbox-cacheable-response.prod.js 610 B 610 B 0% 356 B
packages/workbox-cli/build/app.js 4.16 KB 4.16 KB 0% 1.64 KB
packages/workbox-cli/build/bin.js 940 B 940 B 0% 502 B
packages/workbox-core/build/workbox-core.prod.js 6.84 KB 6.84 KB 0% 2.84 KB
packages/workbox-expiration/build/workbox-expiration.prod.js 3.00 KB 3.00 KB 0% 1.30 KB
packages/workbox-google-analytics/build/workbox-offline-ga.prod.js 1.97 KB 1.97 KB 0% 915 B
packages/workbox-navigation-preload/build/workbox-navigation-preload.prod.js 659 B 659 B 0% 323 B
packages/workbox-precaching/build/workbox-precaching.prod.js 4.95 KB 5.31 KB +7% 2.00 KB
packages/workbox-range-requests/build/workbox-range-requests.prod.js 1.64 KB 1.64 KB 0% 808 B
packages/workbox-routing/build/workbox-routing.prod.js 3.10 KB 3.10 KB 0% 1.35 KB
packages/workbox-strategies/build/workbox-strategies.prod.js 4.10 KB 4.10 KB 0% 1.13 KB
packages/workbox-streams/build/workbox-streams.prod.js 1.44 KB 1.44 KB 0% 698 B
packages/workbox-sw/build/workbox-sw.js 1.34 KB 1.34 KB 0% 746 B
packages/workbox-webpack-plugin/build/generate-sw.js 4.72 KB 4.72 KB 0% 1.76 KB
packages/workbox-webpack-plugin/build/index.js 349 B 349 B 0% 255 B
packages/workbox-webpack-plugin/build/inject-manifest.js 6.67 KB 6.67 KB 0% 2.20 KB
packages/workbox-window/build/workbox-window.dev.umd.js 41.91 KB 41.91 KB 0% 9.29 KB
packages/workbox-window/build/workbox-window.prod.umd.js 4.54 KB 4.54 KB 0% 1.85 KB

Workbox Aggregate Size Plugin

3.54KB gzip'ed (24% of limit)
8.07KB uncompressed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PrecacheController helpers for retrieving responses from the cache
4 participants