Add test of yarn installation, and revert strip-comments version #2416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffposnick
changed the title
philipwalton
approved these changes
Mar 24, 2020
jeffposnick
changed the title
This was referenced Oct 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R: @philipwalton
Fixes #2415
This adds a new test that tries to install our three
nodepackages usingyarn.yarnis stricter aboutenginesversioning thannpmis, so this will presumably catch some things that we wouldn't notice normally from just usingnpm.This also reverts the version of
strip-commentsused byworkbox-buildto one that's compatible withnodev8.(The Windows CI test suite currently uses the latest version of
node, but the OS X test suite usesnodev8.)