Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap node versions in our CI tests #2444

Merged
merged 3 commits into from
Apr 10, 2020
Merged

Swap node versions in our CI tests #2444

merged 3 commits into from
Apr 10, 2020

Conversation

jeffposnick
Copy link
Contributor

R: @philipwalton

Fixes #2443

@jeffposnick jeffposnick requested a review from philipwalton April 7, 2020 13:13
@jeffposnick
Copy link
Contributor Author

So in this PR, our macOS CI tests are now failing with

[14:41:44] 'test-integration' errored after 11 min
[14:41:44] Error: Server terminated early with status 1
    at /Users/runner/runners/2.168.0/work/workbox/workbox/node_modules/selenium-webdriver/remote/index.js:251:52
    at processTicksAndRejections (internal/process/task_queues.js:97:5)
[14:41:44] 'test' errored after 17 min

right at the point where the first Safari test should start, after the Firefox tests complete. Investigating further...

@jeffposnick
Copy link
Contributor Author

I can reproduce the Error: Server terminated early with status 1 error when testing against Safari while running the test suite for the underlying selenium-assistant library. Upgrading to selenium-webdriver ^4.0.0-alpha.7 in that underlying library didn't help, either.

Still investigating, but it does appear to be more of an issue with the testing infrastructure in general and less with anything we're doing in our tests.

@jeffposnick
Copy link
Contributor Author

Okay, it's due to https://github.com/GoogleChromeLabs/selenium-assistant/blob/92a799db2025b08bc698a9bcf84f61e5d4142638/src/local-browsers/safari.js#L64-L69, which was a workaround for Safari >= 12 that doesn't appear to be necessary anymore in Safari 13.1.

I am going to push out a new release of selenium-assistant that changes that logic so that it's not in effect for Safari 13.1, and then hopefully the tests will work moving forward.

@jeffposnick
Copy link
Contributor Author

...now Windows is failing due to npm/cli#558

Fun. There are some workarounds in that thread.

@jeffposnick
Copy link
Contributor Author

Okay! That's better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix chromedriver issue with our CI tests
2 participants