-
Notifications
You must be signed in to change notification settings - Fork 823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Swap node versions in our CI tests #2444
Conversation
So in this PR, our macOS CI tests are now failing with
right at the point where the first Safari test should start, after the Firefox tests complete. Investigating further... |
I can reproduce the Still investigating, but it does appear to be more of an issue with the testing infrastructure in general and less with anything we're doing in our tests. |
Okay, it's due to https://github.com/GoogleChromeLabs/selenium-assistant/blob/92a799db2025b08bc698a9bcf84f61e5d4142638/src/local-browsers/safari.js#L64-L69, which was a workaround for Safari >= 12 that doesn't appear to be necessary anymore in Safari 13.1. I am going to push out a new release of |
...now Windows is failing due to npm/cli#558 Fun. There are some workarounds in that thread. |
Okay! That's better. |
R: @philipwalton
Fixes #2443