Don't check swSrc for hardcoded injection point in wizard flow #2451
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R: @philipwalton
Fixes #2447
Using the
wizard
mode in theworkbox-cli
, there was previously a validation step that would check to see if yourswSrc
file contained the manifest injection point. This check wasn't updated for Workbox v5, so it was still looking forprecacheAndRoute([])
.There's already runtime validation that will check for the proper injection point when you run
workbox injectManifest
after you complete thewizard
step. That runtime validation will work properly if you happen to override theinjectionPoint
configuration option, which this previous hardcode assertion didn't support.So I'm just dropping the assertion from the
wizard
flow entirely.