Update precaching to use routing and strategies #2459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipwalton
commented
Apr 16, 2020
philipwalton
commented
Apr 16, 2020
jeffposnick
reviewed
Apr 17, 2020
jeffposnick
approved these changes
Apr 24, 2020
This was referenced May 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R: @jeffposnick
This PR fixes #1857 and fixes #1760 and fixes #1767 and is a slight rewrite of the main
workbox-precachinglogic to leverage the changes added in #2415.These changes don't yet address the use case of passing your own strategy or fetch/match options because I wanted to add the initial set of changes without modifying the API (and changing the tests as little as possible) in order to ensure we're not losing any functionality as part of this change.
Once this is merged I can put together a proposal for how developers could use their own custom strategy for precaching.