[Fix] (Workbox wizard) Manually enter the path of the web app root and unselectable separator

[ognjenjevremovic]

Fixes #2764

R: @jeffposnick @philipwalton

Changes

• Fixed error thrown during the workbox wizard regarding the web application root directory prompt (first question) when Manually enter path option is chosen,
• Made the separator unselectable,
• Extended upon the existing unit tests regarding this functionality.

Checklist

After the changes I ensured that:

• no stylistic or unwanted errors are present, by running npm run gulp lint from the root directory,
• no tests are failing, by running npm run gulp test_node from the root directory,
• build passes with no issues, by running npm run gulp build from the root directory,
• checked the build output locally by:
  • creating a new npm project and installing the workbox (local) package, by running npm i ~/path/to/local/project/workbox/packages/workbox-cli,
  • spawning the workbox wizard from the project, by running ./node_modules/.bin/workbox wizard,
  • checked the functionality manually with cases covered:
    1. no child directories present,
    2. multiple child directories present,
    3. manual input of existing directory,
    4. manual input of non-existing directory.
  • checking the generated workbox-config.js file content after completing the wizard.

Done

• Added/updated unit tests for this change
• Included links to related issues/PRs

[jeffposnick]

Thank you for this! I haven't had time to test the changes locally this week, but I wanted to let you know that it hasn't slipped my mind.

[ognjenjevremovic]

No worries. Thank you for getting back to me.
Please do let me know if there are any changes required prior to merging this, once you get time to review the PR.

I'm closely following the workbox project as I familiarized myself with the codebase over the past week(s).
Although, there aren't as many open issues (especially regarding the cli part that I'm most familiar with) I'll be sure to follow the progress and bug reports and try to contribute to the project as much as I can.
Also, I'll try to keep up with the rest of the amazing OSS tools and projects you guys are making freely available for the rest to use and contribute as I see fit.

Thanks and best regards! 🙂

[jeffposnick]

Thank you! There are just some naming issues to resolve.

[jeffposnick]

Thanks again! We'll cut a new release that includes these fixes within a week or so.