-
Notifications
You must be signed in to change notification settings - Fork 804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fire controlling event more than once (#2817) #2857
Fire controlling event more than once (#2817) #2857
Conversation
Dispatches the `controlling` event every time the documentation specifies that it should.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
My employer, State Farm, has signed a CLA. Can you tell me who the point of contact is to be added to the list of people authorized to contribute? |
@rockwalrus I just want to confirm that you are using your State Farm email to create the commit? |
Just as an FYI, we're bundling up a few "ideally not breaking, but let's be careful and try them out first" changes into an upcoming We haven't forgotten about the PR, but are wrapping up a few other changes first. Thanks! |
Yes, I am using my State Farm email for the commit. |
Thanks again for this contribution, @rockwalrus! There's currently at least one failing test:
|
(I'm happy to fix up the tests if you don't mind.) |
Go ahead! There seems to be some flakiness in the tests on my machine that I haven't been able to isolate yet. Thanks! |
So it turns out that I don't have permission to push directly to the In any case, here are the three lines that should get the tests passing in the Hopefully you can apply that change yourself; otherwise, I think we'd have to close this PR and I would open a new one (giving you credit in the release notes, of course). |
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
By the way this is the person you need to check with about being a verified contributor for the CLA: Elizabeth Fox Anvick (Infrastructure Analyst-Open Systems) elizabeth.foxanvick.lpjz@statefarm.com |
I swear that used to be possible, but it's possible something has been changed.
Merged and pushed. |
Elizabeth has moved to another position in the company and no longer seems to have access to this group. How do we go about recovering access to https://groups.google.com/d/forum/state-farm-insurance? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for contributing this change! There is some unrelated flakiness in the workbox-broadcast-update
tests that I'll look into separate from this PR, so as not to delay things further.
R: @jeffposnick @tropicadri
Fixes #2817
Description of what's changed/fixed.
Dispatches the
controlling
event every time the documentation specifies that it should.