Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R: @tropicadri
Fixes #2912
This uses the latest
chokidar
3.x directly, instead of relying on theglob-watcher
wrapper which usedchokidar
2.x under the hood. This resolves some compatibility issues withchokidar
2.x.In the course of making these changes, I also realized that
workbox-cli
wasn't properly reading the newworkbox-build
TypeScript definitions, as it had an override module in place. This PR removes that override module and takes better advantage of the new types internally.Since
workbox-cli
is run as a transpiled binary and not intended to be loaded as a module by third-party code, I think that swapping out the internal type definitions should be considered a non-breaking change.