Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default cli ignores #609

Merged
merged 3 commits into from
Jun 9, 2017
Merged

Default cli ignores #609

merged 3 commits into from
Jun 9, 2017

Conversation

gauntface
Copy link

R: @jeffposnick @addyosmani @gauntface

Fixes #326

Ignore node_modules by default

addyosmani
addyosmani requested changes Jun 9, 2017
View reviewed changes
Copy link
Member

@addyosmani addyosmani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a note to the CLI docs letting folks know about node_modules being ignored?

@gauntface
Copy link
Author

@addyosmani which docs would you like this referenced in?

@addyosmani
Copy link
Member

As discussed this would be good to add a note to the microsite for https://workboxjs.org/get-started/npm-script.

addyosmani
addyosmani approved these changes Jun 9, 2017
View reviewed changes
Copy link
Member

@addyosmani addyosmani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@addyosmani addyosmani merged commit be8e5eb into master Jun 9, 2017
@addyosmani addyosmani deleted the default-cli-ignores branch June 9, 2017 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addyosmani addyosmani addyosmani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gauntface @addyosmani