Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for registering non-GET via runtimeCaching #662

Merged
merged 2 commits into from
Jul 5, 2017
Merged

Support for registering non-GET via runtimeCaching #662

merged 2 commits into from
Jul 5, 2017

Conversation

jeffposnick
Copy link
Contributor

R: @addyosmani @gauntface
CC: @samthor

Fixes #661

This follows from #644, since we can now support passing in non-GET methods via workboxSW.registerRoute().

addyosmani
addyosmani approved these changes Jul 5, 2017
View reviewed changes
Copy link
Member

@addyosmani addyosmani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After seeing #644 land, this one LGTM.

@addyosmani addyosmani merged commit e49f3aa into master Jul 5, 2017
@addyosmani addyosmani deleted the runtime-caching-non-gets branch July 5, 2017 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addyosmani addyosmani addyosmani approved these changes

@gauntface gauntface Awaiting requested review from gauntface

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeffposnick @addyosmani