Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add use strict to generate-sw for Node 4 support #670

Merged
merged 1 commit into from
Jul 13, 2017

Conversation

MaxLeiter
Copy link

@MaxLeiter MaxLeiter commented Jul 10, 2017

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@MaxLeiter
Copy link
Author

Signed

@googlebot
Copy link

CLAs look good, thanks!

@jeffposnick
Copy link
Contributor

Thanks for the contribution, @MaxLeiter!

I'd like to move the discussion to #669 in lieu of merging this PR as-is. I know that there are other files inside of workbox-build that are using const and let, so I have a feeling that the change in this PR wouldn't be sufficient. We should talk about addressing it in a more holistic fashion.

@addyosmani addyosmani added the Chillin' Not being actively worked on, or deferred for a point in the future. label Jul 11, 2017
@MaxLeiter
Copy link
Author

Should be good to go. Ping @jeffposnick

@gauntface
Copy link

Was looking into adding testing for node 4 but it's going to be a pretty big headache since selenium doesn't support anything lower than node 6.

@jeffposnick I'm fine with taking this PR, any other comments from you?

@gauntface gauntface removed the Chillin' Not being actively worked on, or deferred for a point in the future. label Jul 13, 2017
@jeffposnick
Copy link
Contributor

👍

@jeffposnick jeffposnick merged commit a9eba40 into GoogleChrome:master Jul 13, 2017
@MaxLeiter MaxLeiter deleted the patch-1 branch July 13, 2017 18:08
@MaxLeiter
Copy link
Author

any chance of a 1.1.1 release?

@jeffposnick
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants