-
Notifications
You must be signed in to change notification settings - Fork 830
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add use strict to generate-sw for Node 4 support #670
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
Signed |
CLAs look good, thanks! |
Thanks for the contribution, @MaxLeiter! I'd like to move the discussion to #669 in lieu of merging this PR as-is. I know that there are other files inside of |
Should be good to go. Ping @jeffposnick |
Was looking into adding testing for node 4 but it's going to be a pretty big headache since selenium doesn't support anything lower than node 6. @jeffposnick I'm fine with taking this PR, any other comments from you? |
👍 |
any chance of a |
R: @jeffposnick @addyosmani @gauntface
Fixes #670