fixed: bug that causes passed in manifestTransforms not to run #715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gauntface
approved these changes
Aug 3, 2017
|
Thanks for the PR |
|
@gauntface no problem. Any idea when you'd publish another version? |
|
Thanks, @HenrikJoreteg! We've been trying to stick to a bi-weekly release schedule (unless there's a P0 issue that needs immediate resolution), with the next release planned for Wednesday, August 9. We appreciate your patience! |
|
For anyone reading this, a team calendar (with release schedule) can be found here: https://workboxjs.org/community.html |
|
|
|
@jeffposnick @gauntface thanks folks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R: @jeffposnick @addyosmani @gauntface
Fixes issue of custom
manifestTransformsnever being ran as described here: https://github.com/GoogleChrome/workbox/pull/712/files#r131218250If you'd rather fix it as part of the other PR feel free to close this one, just figured I'd throw it out there if you folks wanted to fix this in a hurry.