Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP format-code presubmit check #1032

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

emaxx-google
Copy link
Collaborator

@emaxx-google emaxx-google commented Sep 8, 2023

Integrate clang-format as a CI action check.

@emaxx-google emaxx-google force-pushed the format-code--check-only-mode branch 23 times, most recently from 141631f to 06a92aa Compare September 8, 2023 17:09
Add new parameter "--check-only" to the format-code.py script.

It's primarily intended to be used in CI actions, for checking for
improperly-formatted code.
@emaxx-google emaxx-google changed the title [style] Add --check-only to format-code script WIP format-code presubmit check Sep 11, 2023
@emaxx-google
Copy link
Collaborator Author

This is blocked on the fact that the default version of clang-format on Google developer machines formats the code differently than the currently latest official release. A probable solution would be to not use the system-installed clang-format and instead download one in env/initialize.sh, but it's not immediately clear to me how to do this properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant