[mv3] Collect logs from all pages via messaging #1179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emaxx-google
force-pushed
the
manifest-v3-logs-sending
branch
2 times, most recently
from
a09062e
to
1535e9f
Compare
Use message passing for sending logs to the Service Worker (or the Background Page, when compiled for mv2 Apps) from all other pages of the extension. This replaces the mv2-specific mechanism that collected all logs by directly accessing the background page's LogBuffer variable. This mechanism was a bit hacky, but had the benefit of being synchronous and zero-overhead; it's not viable in mv3 Service Workers so has to be deleted.
emaxx-google
force-pushed
the
manifest-v3-logs-sending
branch
from
1535e9f
to
91253e4
Compare
AleksMat
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use message passing for sending logs to the Service Worker (or the Background Page, when compiled for mv2 Apps) from all other pages of the extension.
This replaces the mv2-specific mechanism that collected all logs by directly accessing the background page's LogBuffer variable. This mechanism was a bit hacky, but had the benefit of being synchronous and zero-overhead; it's not viable in mv3 Service Workers so has to be deleted.