[mv3] Pass received logs to systemLog #1180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emaxx-google
force-pushed
the
manifest-v3-logs-sending
branch
from
a09062e
to
1535e9f
Compare
emaxx-google
force-pushed
the
manifest-v3-system-logs
branch
from
c2d8d87
to
1f943b7
Compare
emaxx-google
force-pushed
the
manifest-v3-logs-sending
branch
from
1535e9f
to
91253e4
Compare
emaxx-google
force-pushed
the
manifest-v3-system-logs
branch
from
1f943b7
to
44389cd
Compare
AleksMat
approved these changes
Jul 23, 2024
Make the Service Worker / Background Page responsible for calling chrome.systemLog API with every log message. Before this commit, every page made its own chrome.systemLog API calls for every of its own logs. However, this doesn't work with mv3 Offscreen Documents, as chrome.systemLog API isn't exposed to them.
emaxx-google
force-pushed
the
manifest-v3-system-logs
branch
from
44389cd
to
1fd5dd4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the Service Worker / Background Page responsible for calling chrome.systemLog API with every log message.
Before this commit, every page made its own chrome.systemLog API calls for every of its own logs. However, this doesn't work with mv3 Offscreen Documents, as chrome.systemLog API isn't exposed to them.