[mv3] Support logs export #1181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AleksMat
approved these changes
Jul 23, 2024
emaxx-google
force-pushed
the
manifest-v3-system-logs
branch
from
44389cd
to
1fd5dd4
Compare
Make the log export UI mv3-compatible, by switching it from directly inspecting the background page's log buffer to using message passing.
emaxx-google
force-pushed
the
manifest-v3-logs-export
branch
from
a3d4be6
to
d8c2df1
Compare
|
I've pushed another commit that shouldn't make functional changes, but seems to greatly improve RAM consumption in practice (~3 MB of overhead instead of ~30 MB for the typical 2'000 log entries). Seems that V8's garbage collection is very lazy :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the log export UI mv3-compatible, by switching it from directly inspecting the background page's log buffer to using message passing.