Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix function type error in README #20

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ahuglajbclajep
Copy link

@ahuglajbclajep ahuglajbclajep commented Feb 27, 2020

Fix type error of greet function in README.
See also #1.

Also, TypeScript does not allow the addition of ".ts" when importing *.ts.
https://www.typescriptlang.org/docs/handbook/modules.html#import
I also fix the README small mistake about this behavior.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@ahuglajbclajep
Copy link
Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@ahuglajbclajep
Copy link
Author

@developit I’d love your feedback, please review my PR.

@gfoidl
Copy link

gfoidl commented Aug 11, 2020

Maybe in the webpack.config.js there should also be a comment about additional loaders for typescript, like ts-loader?

So the config looks like:

module.exports = {
  module: {
    rules: [
      {
        test: /\.worker\.(js|ts)$/i,
        use: [{
          loader: 'comlink-loader',
          options: {
            singleton: true
          }
        },
        "ts-loader"]
      }
    ]
  }
}

Otherwise there will / may be build-failures like

 Module parse failed: Unexpected token (2:25)
    File was processed with these loaders:
     * ../../node_modules/comlink-loader/dist/comlink-worker-loader.js
    You may need an additional loader to handle the result of these loaders.
    | import { expose } from 'comlink';
    ...

@ahuglajbclajep
Copy link
Author

ahuglajbclajep commented Aug 12, 2020

@gfoidl The README is correct in this regard, as it works if you write the comlink-loader first, as shown below.

module.exports = {
  module: {
    rules: [
      {
        test: /\.worker\.[tj]s$/,
        loader: "comlink-loader?singleton",
      },
      {
        test: /\.[tj]sx?$/,
        loader: "ts-loader",
        exclude: /node_modules/,
      }
    ]
  }
}

@gfoidl
Copy link

gfoidl commented Aug 12, 2020

Ahhh, that's good to know. Thank you very much! 👍 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants