-
Notifications
You must be signed in to change notification settings - Fork 390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider not using constructors for API proxy creation #1
Comments
So would you disallow The more I worked with this, the more I have gotten to like But I see your point that when you are trying to actually unpack the data structure in your head, it might not make sense right away. |
Also GoogleChromeLabs/tasklets#9 might be relevant/of your interest |
Gonna close this for now :) |
…ethod-types Add types for symbol methods
Just subjective opinion here, but a line like this:
is a little confusing to me - it makes me think that
api.App
is a Promise, but then what type does the Promise resolve? I know it's a thennable that returns itself, but I think that ability of thennables probably goes over most people's heads. I think it'd be a little clearer with just a factory method:The text was updated successfully, but these errors were encountered: