Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumping dependencies #88

Merged
merged 1 commit into from
Apr 25, 2017
Merged

Bumping dependencies #88

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 4 additions & 9 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,34 +36,29 @@
"eslint-config-google": "^0.7.1",
"express": "^4.14.0",
"firebase": "^3.5.1",
"geckodriver": "^1.3.0",
"geckodriver": "^1.6.0",
"glob": "^7.1.1",
"istanbul": "^0.4.5",
"jsdoc": "^3.4.1",
"mocha": "^3.1.2",
"operadriver": "^1.0.0",
"proxyquire": "^1.7.10",
"sinon": "^1.17.6"
"sinon": "^2.1.0"
},
"dependencies": {
"chalk": "^1.1.3",
"del": "^2.2.0",
"dmg": "^0.1.0",
"fs-extra": "^1.0.0",
"fs-extra": "^2.1.2",
"mkdirp": "^0.5.1",
"node-localstorage": "^1.3.0",
"request": "^2.78.0",
"sauce-connect-launcher": "^1.0.0",
"selenium-webdriver": "3.0.1",
"selenium-webdriver": "3.4.0",
"semver": "^5.3.0",
"which": "^1.2.11",
"yauzl": "^2.7.0"
},
"optionalDependencies": {
"chromedriver": "^2.26.1",
"geckodriver": "^1.2.0",
"operadriver": "^1.0.0"
},
"files": [
"src/"
]
Expand Down
6 changes: 3 additions & 3 deletions test/browser-usage.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ describe('Test Usage of Browsers', function() {

it('should get null for raw version output if no executable found', function() {
sinonStubs.push(
sinon.stub(localBrowser, 'getExecutablePath', () => {
sinon.stub(localBrowser, 'getExecutablePath').callsFake(() => {
return null;
})
);
Expand All @@ -130,7 +130,7 @@ describe('Test Usage of Browsers', function() {

it('should get -1 for version number if no executable found', function() {
sinonStubs.push(
sinon.stub(localBrowser, 'getExecutablePath', () => {
sinon.stub(localBrowser, 'getExecutablePath').callsFake(() => {
return null;
})
);
Expand All @@ -144,7 +144,7 @@ describe('Test Usage of Browsers', function() {

it('should get -1 for an unexpected raw version string', function() {
sinonStubs.push(
sinon.stub(localBrowser, 'getRawVersionString', () => {
sinon.stub(localBrowser, 'getRawVersionString').callsFake(() => {
return 'ImTotallyMadeUp 12345678.asdf.12345678.asdf';
})
);
Expand Down
11 changes: 6 additions & 5 deletions test/expiration-behavior.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,19 +104,20 @@ describe('Test Download Manager - Browser Expiration', function() {
before(function() {
seleniumAssistant.setBrowserInstallDir(testPath);

const dlChromeStub = sinon.stub(downloadManager, '_downlaodChrome',
(release, installDir) => {
const dlChromeStub = sinon.stub(downloadManager, '_downlaodChrome')
.callsFake((release, installDir) => {
browserDownloads.chrome[release] = true;
return Promise.resolve();
});

const dlFFStub = sinon.stub(downloadManager, '_downloadFirefox',
(release, installDir) => {
const dlFFStub = sinon.stub(downloadManager, '_downloadFirefox')
.callsFake((release, installDir) => {
browserDownloads.firefox[release] = true;
return Promise.resolve();
});

const isValidStub = sinon.stub(LocalBrowser.prototype, 'isValid', () => {
const isValidStub = sinon.stub(LocalBrowser.prototype, 'isValid')
.callsFake(() => {
return true;
});

Expand Down
9 changes: 6 additions & 3 deletions test/local-browser.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,8 @@ describe('LocalBrowser', function() {

// getPrettyReleaseNames needs to be stubbed since we are instantiating
// LocalBrowser directly rather than extending it.
const stub = sinon.stub(LocalBrowser, 'getPrettyReleaseNames', () => {
const stub = sinon.stub(LocalBrowser, 'getPrettyReleaseNames')
.callsFake(() => {
return releaseNames;
});
sinonStubs.push(stub);
Expand Down Expand Up @@ -253,7 +254,8 @@ describe('LocalBrowser', function() {
'exampledriver': null,
});

const stub = sinon.stub(ProxiedLocalBrowser, 'getPrettyReleaseNames', () => {
const stub = sinon.stub(ProxiedLocalBrowser, 'getPrettyReleaseNames')
.callsFake(() => {
return releaseNames;
});
sinonStubs.push(stub);
Expand Down Expand Up @@ -281,7 +283,8 @@ describe('LocalBrowser', function() {
},
});

const stub = sinon.stub(ProxiedLocalBrowser, 'getPrettyReleaseNames', () => {
const stub = sinon.stub(ProxiedLocalBrowser, 'getPrettyReleaseNames')
.callsFake(() => {
return releaseNames;
});
sinonStubs.push(stub);
Expand Down
4 changes: 2 additions & 2 deletions test/selenium-assistant.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ describe('SeleniumAssistant', function() {
this.timeout(NUM_OF_BROWSERS * 3000 * 1000);

let consoleCalls = 0;
const stub = sinon.stub(console, 'log', (input) => {
const stub = sinon.stub(console, 'log').callsFake((input) => {
consoleCalls++;
});
sinonStubs.push(stub);
Expand All @@ -121,7 +121,7 @@ describe('SeleniumAssistant', function() {
this.timeout(NUM_OF_BROWSERS * 3000 * 1000);

let consoleCalls = 0;
const stub = sinon.stub(console, 'log', () => {
const stub = sinon.stub(console, 'log').callsFake(() => {
consoleCalls++;
});
sinonStubs.push(stub);
Expand Down