Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forces headless mode for Chrome #93

Closed
wants to merge 1 commit into from
Closed

Conversation

jeffposnick
Copy link
Contributor

As discussed.

This seems to work, but it's entirely possible that this should be optional, or implemented in a different subclass of the Chrome config or something. Feel free to tell me I'm doing it wrong 😄

@jeffposnick jeffposnick requested a review from gauntface June 23, 2017 18:55
@ebidel
Copy link

ebidel commented Jun 23, 2017

FWIW, there are still bugs with using Selenium with headless atm. Not sure if want to default to it just yet.

@jeffposnick
Copy link
Contributor Author

Could you pass along the links to any showstoppers that we could Star and keep tabs on?

@ebidel
Copy link

ebidel commented Jun 23, 2017

This is the master bug: https://bugs.chromium.org/p/chromium/issues/detail?id=604324

There's a doc in there with a list of things that are missing. A major one is screenshots don't work yet.

@jeffposnick
Copy link
Contributor Author

Thanks for that context! None of the issues in the doc seem relevant to the projects I use selenium-assistant for, but I guess there are other folks out there using it for different testing scenarios that might be impacted.

I'll defer to @gauntface as to whether this is something he'd like to see on by default. If not, perhaps there's an alternative solution for end-user configuration that would also fix #90 at the same time.

@gauntface
Copy link

This should be optional.

@gauntface
Copy link

Is this not possible by getting the selenium options and adding the flag there?

https://googlechrome.github.io/selenium-assistant/reference-docs/stable/v5.0.5/LocalBrowser.html#getSeleniumOptions

If so, it would be better to just add a new doc page to cover how it can be done.

@gauntface
Copy link

Closed in favor #97

@gauntface gauntface closed this Aug 23, 2017
@jeffposnick jeffposnick deleted the headless-chrome branch April 10, 2020 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants