-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace deprecated terser plugin #1423
Conversation
... Turns out we were also still on Node 14 in So this PR also updates to Node 20 LTS. |
No idea why Windows is failing or what I need to do to fix it 😕 |
Judging purely from the error report, this could be the issue? It's a breaking change in node for Windows users |
@aryanpingle Great find! That seems to have resolved that issue, however now there’s a new path issue 🙄 I’ll see if I can spin up a Windows workstation somewhere... |
@surma GH actions runs In the future if we need to use the port number elsewhere we can just declare it separately |
Thank you! |
rollup-plugin-terser
has been long deprecated and replaced by@rollup/plugin-terser
.I discovered this during some Wasm work, where Emscripten now emits code using
??=
which the older terser does not understand. The switch to@rollup/plugin-terser
fixes that.There are lots of outdated dependencies, but rather than do a massive PR I figured I’d do it one step at a time.