This repository has been archived by the owner on Aug 31, 2021. It is now read-only.
Bump version selenium-assistant #23
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To fix naming of Firefox Nightly on macOS.
martijndwars
force-pushed
the
bump-selenium-assistant
branch
from
5351a82 to
01ee7a6
Compare
peter279k
approved these changes
Dec 31, 2019
peter279k
added a commit
to open-source-contributions/web-push-testing-service
that referenced
this pull request
Dec 31, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to run web-push-testing-service 0.4.0, but it fails because it cannot find
FirefoxNightly.appafter mounting the .dmg. I noticed that there was aFirefox Nightly.appon the file system. It looks like selenium-assistant 5.3.0 fixed this a while back, but web-push-testing-service still uses selenium-assistant 5.2.0.This PR:
npm i selenium-assistant)Let me know if this is okay or if it needs any improvements.