-
Notifications
You must be signed in to change notification settings - Fork 976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CassandraToBigtable classic template feature: Cassandra Writetime replication #1653
Conversation
v1/src/main/java/com/google/cloud/teleport/bigtable/CassandraToBigtable.java
Show resolved
Hide resolved
@GoogleCloudPlatform/dataflow-templates-wg |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution! I left a couple small comments for core templates related files. Please tag a member from the BigTable team to review BigTable-related changes
v1/src/main/java/com/google/cloud/teleport/util/GCSAwareValueProvider.java
Show resolved
Hide resolved
...e-cloud-platform/src/main/java/org/apache/beam/it/gcp/bigtable/matchers/BigtableAsserts.java
Outdated
Show resolved
Hide resolved
…ed pom.xml import version for datastax query builder, changed CharStreams import in GCSUtils
v1/src/main/java/com/google/cloud/teleport/bigtable/BeamRowToBigtableFn.java
Outdated
Show resolved
Hide resolved
v1/src/main/java/com/google/cloud/teleport/bigtable/BeamRowToBigtableFn.java
Show resolved
Hide resolved
v1/src/main/java/com/google/cloud/teleport/bigtable/BeamRowToBigtableFn.java
Show resolved
Hide resolved
v1/src/main/java/com/google/cloud/teleport/bigtable/BeamRowToBigtableFn.java
Outdated
Show resolved
Hide resolved
v1/src/main/java/com/google/cloud/teleport/bigtable/CassandraColumnSchema.java
Show resolved
Hide resolved
v1/src/main/java/com/google/cloud/teleport/bigtable/CassandraColumnSchema.java
Show resolved
Hide resolved
v1/src/main/java/com/google/cloud/teleport/bigtable/CassandraColumnSchema.java
Show resolved
Hide resolved
v1/src/main/java/com/google/cloud/teleport/bigtable/CassandraToBigtable.java
Outdated
Show resolved
Hide resolved
v1/src/test/java/com/google/cloud/teleport/bigtable/BeamRowToBigtableFnTest.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please go through all the warnings of lines not covered by tests and add any relevant Tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ack. will merge after fixing the format (mv. spotless:apply)
cc: @Polber looks like merge is still blocked pending your approval |
@Polber Is there anything pending from the CBT side? can we merge this change? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Add Cassandra writetime replication feature to CassandraToBigtable classic template.
Cassandra writetime can now be replicated to Bigtable as Bigtable cell timestamp. For this feature to work, users have to upload a json-like schema file to a GCS bucket location first for the table they wish to replicate writetimes for. The command to generate this schema file is:
Then, to upload the file:
The schema GCS file path should then be set as $WRITETIME_CASSANDRA_COLUMN_SCHEMA to be parsed by the template at run time.
The template replication behavior now sets Bigtable cell time as replication time (i.e. now) instead of epoch start time previously. SetZeroTimestamp is the backwards compatibility option to set 0 as the timestamp.
@GoogleCloudPlatform/dataflow-templates-wg