-
Notifications
You must be signed in to change notification settings - Fork 976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pipeline parameter updates #1740
Merged
Deep1998
merged 10 commits into
GoogleCloudPlatform:main
from
bharadwaj-aditya:parameters_update
Aug 1, 2024
Merged
pipeline parameter updates #1740
Deep1998
merged 10 commits into
GoogleCloudPlatform:main
from
bharadwaj-aditya:parameters_update
Aug 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bharadwaj-aditya
requested review from
Deep1998
and removed request for
asthamohta
July 19, 2024 05:06
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1740 +/- ##
============================================
+ Coverage 42.58% 49.42% +6.84%
+ Complexity 3365 1226 -2139
============================================
Files 815 351 -464
Lines 47677 19258 -28419
Branches 5109 1941 -3168
============================================
- Hits 20304 9519 -10785
+ Misses 25717 9085 -16632
+ Partials 1656 654 -1002
|
bharadwaj-aditya
force-pushed
the
parameters_update
branch
from
July 31, 2024 05:21
4b65e37
to
7f1bce2
Compare
...cedb-to-spanner/src/main/java/com/google/cloud/teleport/v2/templates/PipelineController.java
Outdated
Show resolved
Hide resolved
VardhanThigle
previously approved these changes
Aug 1, 2024
VardhanThigle
previously approved these changes
Aug 1, 2024
Deep1998
reviewed
Aug 1, 2024
Deep1998
reviewed
Aug 1, 2024
...src/main/java/com/google/cloud/teleport/v2/spanner/migrations/schema/SessionBasedMapper.java
Outdated
Show resolved
Hide resolved
Deep1998
reviewed
Aug 1, 2024
Deep1998
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to the parameters