Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pipeline parameter updates #1740

Merged
merged 10 commits into from
Aug 1, 2024

Conversation

bharadwaj-aditya
Copy link
Contributor

@bharadwaj-aditya bharadwaj-aditya commented Jul 19, 2024

Changes to the parameters

  1. Table seperator changed to pipe and comma - to support gcloud handling
  2. removed hard checks on session file mapping
  3. Converted RPC priority to high
  4. Rename sourceDB url to sourceConfig url

@bharadwaj-aditya bharadwaj-aditya requested a review from a team as a code owner July 19, 2024 05:06
@bharadwaj-aditya bharadwaj-aditya requested review from Deep1998 and removed request for asthamohta July 19, 2024 05:06
Copy link

codecov bot commented Jul 19, 2024

Codecov Report

Attention: Patch coverage is 82.60870% with 4 lines in your changes missing coverage. Please review.

Project coverage is 49.42%. Comparing base (8fb7b89) to head (571c2c4).
Report is 3 commits behind head on main.

Files Patch % Lines
...loud/teleport/v2/templates/PipelineController.java 33.33% 2 Missing ⚠️
...cloud/teleport/v2/templates/SourceDbToSpanner.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1740      +/-   ##
============================================
+ Coverage     42.58%   49.42%   +6.84%     
+ Complexity     3365     1226    -2139     
============================================
  Files           815      351     -464     
  Lines         47677    19258   -28419     
  Branches       5109     1941    -3168     
============================================
- Hits          20304     9519   -10785     
+ Misses        25717     9085   -16632     
+ Partials       1656      654    -1002     
Components Coverage Δ
spanner-templates 64.84% <82.60%> (+0.27%) ⬆️
spanner-import-export ∅ <ø> (∅)
spanner-live-forward-migration 75.37% <100.00%> (+0.37%) ⬆️
spanner-live-reverse-replication 52.28% <100.00%> (+0.31%) ⬆️
spanner-bulk-migration 83.69% <82.60%> (+0.22%) ⬆️
Files Coverage Δ
...ud/teleport/v2/options/OptionsToConfigBuilder.java 87.14% <100.00%> (+0.37%) ⬆️
.../spanner/migrations/schema/SessionBasedMapper.java 100.00% <100.00%> (ø)
...loud/teleport/v2/templates/PipelineController.java 20.27% <33.33%> (-0.15%) ⬇️
...cloud/teleport/v2/templates/SourceDbToSpanner.java 31.57% <0.00%> (ø)

... and 489 files with indirect coverage changes

@pull-request-size pull-request-size bot added size/L and removed size/M labels Jul 31, 2024
VardhanThigle
VardhanThigle previously approved these changes Aug 1, 2024
VardhanThigle
VardhanThigle previously approved these changes Aug 1, 2024
@Deep1998 Deep1998 merged commit c1b3d7f into GoogleCloudPlatform:main Aug 1, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants