Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1677 changed the way that
maven-compiler-plugin
compiles annotation processors from being implicit to explicitly defined. The definition for@AutoValue
annotations was added, but not@AutoService
.This caused the
CommonTemplateJvmInitializer
to not get compiled into the template jars with the@AutoService
handler, which resulted in Beam not calling the necessary Jvm initialization methods for certain templates to work properly.DataflowTemplates/v1/src/main/java/com/google/cloud/teleport/templates/common/CommonTemplateJvmInitializer.java
Lines 40 to 44 in 0d01acc
This was namely an issue with JDBC templates for users that rely on the
--extraFilesToStage
parameter to copy files from GCS to theextra_files
directory on the Dataflow worker.This PR adds the definition for the
@AutoService
annotation processor to affected modules.