Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Timestamp in proto to bigquery schema conversion #1789

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

Abacn
Copy link
Contributor

@Abacn Abacn commented Aug 14, 2024

For example, in PubSub_Proto_to_BigQuery_Xlang, when there is a Timestamp field, it get inferred to a BigQuery RECORD field of {"seconds": "INTEGER", "nanos": "INTEGER"}, i.e., google.protobuf.Timestamp gets expanded.

@Abacn
Copy link
Contributor Author

Abacn commented Aug 14, 2024

Internal bug: 355704665

Copy link

codecov bot commented Aug 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.99%. Comparing base (9ee87ca) to head (102e966).
Report is 6 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1789      +/-   ##
============================================
- Coverage     43.02%   42.99%   -0.03%     
- Complexity     3404     3406       +2     
============================================
  Files           817      818       +1     
  Lines         47730    47783      +53     
  Branches       5122     5129       +7     
============================================
+ Hits          20535    20544       +9     
- Misses        25533    25578      +45     
+ Partials       1662     1661       -1     
Components Coverage Δ
spanner-templates 63.88% <ø> (+0.01%) ⬆️
spanner-import-export 64.31% <ø> (+0.04%) ⬆️
spanner-live-forward-migration 75.17% <ø> (ø)
spanner-live-reverse-replication 71.62% <ø> (ø)
spanner-bulk-migration 83.85% <ø> (ø)
Files Coverage Δ
...om/google/cloud/teleport/v2/utils/SchemaUtils.java 86.66% <100.00%> (+0.95%) ⬆️

... and 2 files with indirect coverage changes

@Abacn
Copy link
Contributor Author

Abacn commented Aug 14, 2024

R: @Polber

@Abacn
Copy link
Contributor Author

Abacn commented Aug 19, 2024

Four attempts all have different tests failing, not related to the change

@Polber Polber merged commit 5bd01d2 into GoogleCloudPlatform:main Aug 19, 2024
11 of 13 checks passed
@Abacn Abacn deleted the protoschema branch August 21, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants