Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix release staging #1992

Merged

Conversation

Polber
Copy link
Contributor

@Polber Polber commented Nov 5, 2024

The release is failing to stage because for some reason Cloud Build commands always return non-zero exit code when run as java subprocess (even when successful). This PR refactors the recently added cloud build command from throwing an exception to logging a WARN.

Signed-off-by: Jeffrey Kinard <jeff@thekinards.com>
@Polber Polber requested a review from damccorm November 5, 2024 23:09
@Polber Polber self-assigned this Nov 5, 2024
Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.26%. Comparing base (ba67089) to head (8920ff9).
Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1992      +/-   ##
============================================
- Coverage     45.27%   45.26%   -0.01%     
+ Complexity     3632     3630       -2     
============================================
  Files           836      836              
  Lines         49872    49872              
  Branches       5253     5253              
============================================
- Hits          22579    22575       -4     
- Misses        25618    25622       +4     
  Partials       1675     1675              
Components Coverage Δ
spanner-templates 66.61% <ø> (-0.01%) ⬇️
spanner-import-export 64.16% <ø> (-0.03%) ⬇️
spanner-live-forward-migration 75.86% <ø> (ø)
spanner-live-reverse-replication 76.63% <ø> (ø)
spanner-bulk-migration 86.42% <ø> (ø)

see 2 files with indirect coverage changes

@Polber Polber merged commit 4675f9d into GoogleCloudPlatform:main Nov 6, 2024
12 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants