Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix aws on windows #313

Merged
merged 2 commits into from
Jun 17, 2015
Merged

Fix aws on windows #313

merged 2 commits into from
Jun 17, 2015

Commits on Jun 17, 2015

  1. Fix AWS on windows 

    The AWS CLI does not correctly set either $LastExitCode or $? when it
fails. This leads to us thinking a command succeeded when it didn't.
By adding the option to retry the command in IssueRetryableCommand when
there is output on stderr, we can work around this.
    @ehankland
    ehankland committed Jun 17, 2015
    Configuration menu
    Copy the full SHA
    90d4a08 View commit details
    Browse the repository at this point in the history

  2. Respond to review comments

    @ehankland
    ehankland committed Jun 17, 2015
    Configuration menu
    Copy the full SHA
    a431f9f View commit details
    Browse the repository at this point in the history