Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add latency percentiles for fio results. #344

Merged
merged 6 commits into from
Jun 26, 2015
Merged

Add latency percentiles for fio results. #344

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
55a9c3c
Add latency percentiles for fio results.
yuyantingzero Jun 25, 2015
f9c0297
Fix lint.
yuyantingzero Jun 25, 2015
b988aea
Add latency percentiles for fio results.
yuyantingzero Jun 25, 2015
2eba09a
Fix lint.
yuyantingzero Jun 25, 2015
aec88e9
Address comments.
yuyantingzero Jun 25, 2015
40ef16b
Resolve conflict.
yuyantingzero Jun 25, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion perfkitbenchmarker/packages/fio.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,13 @@ def ParseResults(job_file, fio_json_result):
lat_metadata = {
'min': job[mode]['clat']['min'],
'max': job[mode]['clat']['max'],
'stddev': job[mode]['clat']['stddev']}
'stddev': job[mode]['clat']['stddev'],
'p1': job[mode]['clat']['percentile']['1.000000'],
'p5': job[mode]['clat']['percentile']['5.000000'],
'p50': job[mode]['clat']['percentile']['50.000000'],
'p95': job[mode]['clat']['percentile']['95.000000'],
'p99': job[mode]['clat']['percentile']['99.000000'],
'p99.99': job[mode]['clat']['percentile']['99.990000']}
lat_metadata.update(parameters)
samples.append(
sample.Sample('%s:latency' % metric_name,
Expand Down
20 changes: 15 additions & 5 deletions tests/packages/fio_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,35 +87,45 @@ def testParseFioResults(self):
'bw_min': 19225, 'bw_dev': 20346.28,
'bw_mean': 63936.8}],
['sequential_write:write:latency', 477734.84, 'usec',
{'max': 869891, 'stddev': 92609.34, 'min': 189263}],
{'max': 869891, 'stddev': 92609.34, 'min': 189263,
'p1': 387072, 'p5': 440320, 'p50': 444416,
'p95': 724992, 'p99': 823296, 'p99.99': 872448}],
['sequential_write:write:iops', 133, '', {}],
['sequential_read:read:bandwidth', 129836, 'KB/s',
{'bw_max': 162491, 'bw_agg': 130255.2,
'bw_min': 115250, 'bw_dev': 18551.37,
'bw_mean': 130255.2}],
['sequential_read:read:latency', 250667.06, 'usec',
{'max': 528542, 'stddev': 70403.40, 'min': 24198}],
{'max': 528542, 'stddev': 70403.40, 'min': 24198,
'p1': 59136, 'p5': 116224, 'p50': 264192,
'p95': 366592, 'p99': 473088, 'p99.99': 528384}],
['sequential_read:read:iops', 253, '', {}],
['random_write_test:write:bandwidth', 6443, 'KB/s',
{'bw_max': 7104, 'bw_agg': 6446.55,
'bw_min': 5896, 'bw_dev': 336.21,
'bw_mean': 6446.55}],
['random_write_test:write:latency', 587.02, 'usec',
{'max': 81806, 'stddev': 897.93, 'min': 1}],
{'max': 81806, 'stddev': 897.93, 'min': 1,
'p1': 446, 'p5': 462, 'p50': 510,
'p95': 1064, 'p99': 1688, 'p99.99': 81408}],
['random_write_test:write:iops', 1610, '', {}],
['random_read_test:read:bandwidth', 1269, 'KB/s',
{'bw_max': 1745, 'bw_agg': 1275.52,
'bw_min': 330, 'bw_dev': 201.59,
'bw_mean': 1275.52}],
['random_read_test:read:latency', 3117.62, 'usec',
{'max': 352736, 'stddev': 5114.37, 'min': 0}],
{'max': 352736, 'stddev': 5114.37, 'min': 0,
'p1': 524, 'p5': 588, 'p50': 3280,
'p95': 3440, 'p99': 3728, 'p99.99': 354304}],
['random_read_test:read:iops', 317, '', {}],
['random_read_test_parallel:read:bandwidth', 1292, 'KB/s',
{'bw_max': 1693, 'bw_agg': 1284.71,
'bw_min': 795, 'bw_dev': 88.67,
'bw_mean': 1284.71}],
['random_read_test_parallel:read:latency', 198030.44, 'usec',
{'max': 400078, 'stddev': 21709.40, 'min': 0}],
{'max': 400078, 'stddev': 21709.40, 'min': 0,
'p1': 65280, 'p5': 189440, 'p50': 199680,
'p95': 209920, 'p99': 209920, 'p99.99': 399360}],
['random_read_test_parallel:read:iops', 323, '', {}]]
expected_result = [sample.Sample(*sample_tuple)
for sample_tuple in expected_result]
Expand Down