controller: made QPS, burst QPS and number of workers externally configurable #497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do we want to expose these as helm variables? or wait and see for now if people want to adjust them? |
|
Let me add helm config... |
|
Build Failed 😱 Build Id: a6765e3e-f733-47b3-b02c-1990e64b8b08 Build Logs |
jkowalski
force-pushed
the
qps-throttle
branch
3 times, most recently
from
c2d4816
to
e255d66
Compare
|
Build Failed 😱 Build Id: 02107c6c-840f-4490-bea8-218853ff5e08 Build Logs |
|
Build Failed 😱 Build Id: 45b4f66b-1d20-491b-a791-82f946a7fb8b Build Logs |
|
Build Failed 😱 Build Id: 7b150f78-c2cd-4357-b260-e0693c8dc041 Build Logs |
|
Build Failed 😱 Build Id: 861ccf78-95e0-4a36-898d-4202de932aa0 Build Logs |
jkowalski
force-pushed
the
qps-throttle
branch
from
e255d66
to
5613e92
Compare
|
Build Failed 😱 Build Id: d3d62f89-ff76-4aae-8d5e-b720966682e6 Build Logs |
|
Build Failed 😱 Build Id: 82e2d554-f4b2-436b-a2fc-504e5bc6a0ab Build Logs |
cyriltovena
approved these changes
Jan 24, 2019
|
This looks great, but you got caught by the new website docs causing conflicts for you. Sorry! |
jkowalski
force-pushed
the
qps-throttle
branch
from
5613e92
to
5005cc2
Compare
|
Build Failed 😱 Build Id: f99164c5-4b56-42c3-a4ef-d7eac2febf14 Build Logs |
jkowalski
force-pushed
the
qps-throttle
branch
from
5005cc2
to
53fdb92
Compare
|
Build Failed 😱 Build Id: a0605bb5-1697-4280-8ba4-f2e10984c8f9 Build Logs |
jkowalski
force-pushed
the
qps-throttle
branch
from
53fdb92
to
2cb03ee
Compare
|
Build Failed 😱 Build Id: 57a2e482-0418-4783-9661-0b407f2f1624 Build Logs |
|
Build Failed 😱 Build Id: 41afe322-69db-4ac0-abc2-66130dc6b4b2 Build Logs |
markmandel
added
kind/feature
Closed
jkowalski
force-pushed
the
qps-throttle
branch
from
2cb03ee
to
fa3c8d0
Compare
|
Build Failed 😱 Build Id: 73498a07-3841-403e-824c-ac430117643a Build Logs |
jkowalski
force-pushed
the
qps-throttle
branch
from
fa3c8d0
to
7874896
Compare
|
Build Succeeded 👏 Build Id: 2b362eb8-2645-4f22-b89a-acaa9cf85f69 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website will exist for the next 30 days: To install this version:
|
jkowalski
force-pushed
the
qps-throttle
branch
from
7874896
to
447ca15
Compare
|
Build Succeeded 👏 Build Id: 5ca7a45e-c199-4425-9d7a-51b004bd74f2 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website will exist for the next 30 days: To install this version:
|
|
Build Succeeded 👏 Build Id: 2bda0616-1248-4ae3-824a-b586308d909d The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website will exist for the next 30 days: To install this version:
|
markmandel
reviewed
Jan 26, 2019
| @@ -129,14 +129,17 @@ The following tables lists the configurable parameters of the Agones chart and t | |||
| | `agones.controller.healthCheck.timeoutSeconds` | Number of seconds after which the probe times out (in seconds) | `1` | | |||
| | `agones.controller.resources` | Controller resource requests/limit | `{}` | | |||
| | `agones.controller.generateTLS` | Set to true to generate TLS certificates or false to provide your own certificates in `certs/*` | `true` | | |||
| | `agones.controller.numWorkers` | Number of workers to spin per resource type | `64` | | |||
There was a problem hiding this comment.
This section should be below in the "new configuration features" section. (best way I could handle it in the docs)
jkowalski
force-pushed
the
qps-throttle
branch
from
9b474d9
to
4793542
Compare
|
Build Succeeded 👏 Build Id: 6741a264-2d97-4545-ae79-f5803b814c28 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website will exist for the next 30 days: To install this version:
|
markmandel
reviewed
Jan 26, 2019
test/e2e/gameserver_test.go
Outdated
| }) | ||
|
|
||
| assert.Nil(t, err) | ||
| assert.NotEmpty(t, gs.ObjectMeta.Annotations["stable.agones.dev/sdk-timestamp"]) |
|
Build Succeeded 👏 Build Id: 28cc6095-d61b-4a22-87f9-0e254c3497f5 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website will exist for the next 30 days: To install this version:
|
markmandel
requested changes
Jan 28, 2019
test/e2e/gameserver_test.go
Outdated
| }) | ||
|
|
||
| assert.Nil(t, err) | ||
| assert.NotEmpty(t, gs.ObjectMeta.Annotations["stable.agones.dev/sdk-timestamp"]) |
There was a problem hiding this comment.
Now that #516 is fixed, let's remove this change please.
markmandel
reviewed
Jan 28, 2019
jkowalski
force-pushed
the
qps-throttle
branch
from
6192a05
to
df9bc89
Compare
|
Build Succeeded 👏 Build Id: 0120a0f0-17d7-4c62-a4e8-9d818c9bc2ac The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website will exist for the next 30 days: To install this version:
|
|
Build Succeeded 👏 Build Id: e7c299b9-b7d6-43ed-8a07-7d227a3e82de The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website will exist for the next 30 days: To install this version:
|
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also increased their default values significantly based on scale test results.