Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use GKE version 1.25. Remove PSP and istio from GKE cluster creation. #136

Merged
merged 2 commits into from
Apr 3, 2023
Merged

Use GKE version 1.25. Remove PSP and istio from GKE cluster creation. #136

merged 2 commits into from
Apr 3, 2023

Conversation

soumyapani
Copy link
Collaborator

No description provided.

This was linked to issues Apr 3, 2023
Remove PSP and istio from GKE cluster. #132
Closed
Configure specific version for GKE control plane #129
Closed
stevenBorisko
stevenBorisko reviewed Apr 3, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
sdlin
sdlin approved these changes Apr 3, 2023
View reviewed changes
Copy link
Contributor

@sdlin sdlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these 3 independent changes?

Or are they somehow dependent on one another? Like is there something about the GKE version that requires some of the other changes?

Approved, pending a revert of the inadvertent markdown number change.

@soumyapani
Copy link
Collaborator Author

soumyapani commented Apr 3, 2023 •
edited
Loading

Yes.

  1. first change is setting GKE version to 1.25. We will need to update this version in future so I am considering making it an input as well.
  2. Removing PSP and istio. These are blocking GPU driver installation and removed in 1.25. So I removed those blocks.
  3. Removed manual IP range allocation since GKE takes care of that automatically.

But they are all dependent on each other to allow GPU driver installation.

@suffiank
Copy link
Collaborator

suffiank commented Apr 3, 2023

LGTM ✔️

@soumyapani soumyapani merged commit 1484394 into develop Apr 3, 2023
@soumyapani soumyapani deleted the soumyap/gke-fix-version branch April 3, 2023 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevenBorisko stevenBorisko stevenBorisko approved these changes

@sdlin sdlin sdlin approved these changes

@DmitryKakurin DmitryKakurin Awaiting requested review from DmitryKakurin

@Yf-Xue Yf-Xue Awaiting requested review from Yf-Xue

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove PSP and istio from GKE cluster. Configure specific version for GKE control plane
4 participants
@soumyapani @suffiank @sdlin @stevenBorisko