Support for Multiple Separate TPU Worker Groups per RayCluster #467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardsliu
reviewed
Mar 27, 2024
ryanaoleary
force-pushed
the
multi-worker-groups
branch
2 times, most recently
from
f3b6ced
to
6438777
Compare
richardsliu
reviewed
Apr 2, 2024
ryanaoleary
requested review from
achandrasekar,
ahg-g and
annapendleton
as code owners
ryanaoleary
force-pushed
the
multi-worker-groups
branch
from
f45c60c
to
657b33e
Compare
ryanaoleary
requested review from
richardsliu
and removed request for
achandrasekar,
annapendleton and
ahg-g
|
/gcbrun |
richardsliu
approved these changes
Apr 5, 2024
kfswain
pushed a commit
that referenced
this pull request
Apr 15, 2024
* Support for multiple seperate TPU workergroups per RayCluster * Add namespace to slice struct, logs, and comments * Added unit tests for getReplicaIndex and getNextWorkerID * added two more test cases for edge cases * Fixed comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for multiple worker groups that request TPUs (both single-host and multi-host) in the same Ray Cluster. This PR was tested by manually creating a RayCluster with single-host, multi-host, single-slice, and multi-slice worker groups and verifying that all were injected with the correct
TPU_NAME,TPU_WORKER_ID,replicaIndex, andTPU_WORKER_HOSTNAMES.This PR also adds unit tests for
getReplicaIndexandgetNextWorkerID, these tests can be run usinggo testfrom the applications/ray/kuberay-tpu-webhook folder.