Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests to jupyter notebook in cloudbuild #524

Merged
merged 1 commit into from
Apr 5, 2024
Merged

Add tests to jupyter notebook in cloudbuild #524

merged 1 commit into from
Apr 5, 2024

Conversation

chiayi
Copy link
Collaborator

@chiayi chiayi commented Apr 2, 2024

No description provided.

@chiayi
Copy link
Collaborator Author

chiayi commented Apr 2, 2024

/gcbrun

@chiayi
Copy link
Collaborator Author

chiayi commented Apr 2, 2024

/gcbrun

@chiayi
Copy link
Collaborator Author

chiayi commented Apr 2, 2024

/gcbrun

@chiayi
Copy link
Collaborator Author

chiayi commented Apr 2, 2024

/gcbrun

@chiayi
Copy link
Collaborator Author

chiayi commented Apr 2, 2024

/gcbrun

@chiayi
Copy link
Collaborator Author

chiayi commented Apr 2, 2024

/gcbrun

@chiayi
Copy link
Collaborator Author

chiayi commented Apr 2, 2024

/gcbrun

@chiayi
Copy link
Collaborator Author

chiayi commented Apr 2, 2024

/gcbrun

andrewsykim
andrewsykim reviewed Apr 3, 2024
View reviewed changes
cloudbuild.yaml Outdated Show resolved Hide resolved
cloudbuild.yaml Outdated Show resolved Hide resolved
cloudbuild.yaml Outdated Show resolved Hide resolved
cloudbuild.yaml Outdated Show resolved Hide resolved
@chiayi
Copy link
Collaborator Author

chiayi commented Apr 3, 2024 •
edited

run failed due to not being able to find jupyter-admin pod, I suspect there could be some unique id added to it. Changing it to use kubectl to find the name of the pod.

@chiayi
Copy link
Collaborator Author

chiayi commented Apr 3, 2024

/gcbrun

@chiayi chiayi force-pushed the test-jupyter-notebook branch 3 times, most recently from 31e77dc to 57d0595 Compare April 3, 2024 17:51
@chiayi
Copy link
Collaborator Author

chiayi commented Apr 3, 2024

/gcbrun

@chiayi
Copy link
Collaborator Author

chiayi commented Apr 3, 2024

/gcbrun

@chiayi
Copy link
Collaborator Author

chiayi commented Apr 3, 2024

/gcbrun

@chiayi
Copy link
Collaborator Author

chiayi commented Apr 3, 2024

/gcbrun

1 similar comment
@chiayi
Copy link
Collaborator Author

chiayi commented Apr 3, 2024

/gcbrun

@chiayi chiayi force-pushed the test-jupyter-notebook branch 2 times, most recently from eb2b3ad to d63fe7c Compare April 4, 2024 18:05
@chiayi
Copy link
Collaborator Author

chiayi commented Apr 4, 2024

/gcbrun

andrewsykim
andrewsykim reviewed Apr 4, 2024
View reviewed changes
cloudbuild.yaml Show resolved Hide resolved
cloudbuild.yaml Show resolved Hide resolved
cloudbuild.yaml Outdated Show resolved Hide resolved
@chiayi
Copy link
Collaborator Author

chiayi commented Apr 4, 2024

/gcbrun

@chiayi
Copy link
Collaborator Author

chiayi commented Apr 4, 2024

/gcbrun

@chiayi
Copy link
Collaborator Author

chiayi commented Apr 4, 2024

/gcbrun

@chiayi chiayi changed the title [WIP] Test jupyter notebook Add tests to jupyter notebook in cloudbuild Apr 4, 2024
@chiayi
Copy link
Collaborator Author

chiayi commented Apr 4, 2024

Standard failed due to time out waiting for: error: timed out waiting for the condition on pods/ray-cluster-kuberay-worker-workergroup-rj25x, retrying.

@chiayi
Copy link
Collaborator Author

chiayi commented Apr 4, 2024

/gcbrun

@chiayi
Copy link
Collaborator Author

chiayi commented Apr 4, 2024

hmm this is a new error:

Error: Provider produced inconsistent result after apply

When applying changes to
module.jupyterhub.module.jupyterhub-workload-identity.google_service_account.cluster_service_account[0],
provider "provider[\"registry.terraform.io/hashicorp/google\"]" produced an
unexpected new value: Root resource was present, but now absent.

This is a bug in the provider, which should be reported in the provider's own
issue tracker.

andrewsykim
andrewsykim approved these changes Apr 5, 2024
View reviewed changes
Copy link
Collaborator

@andrewsykim andrewsykim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one minor comment

@andrewsykim
Copy link
Collaborator

/gcbrun

@chiayi
Copy link
Collaborator Author

chiayi commented Apr 5, 2024

/gcbrun

@chiayi chiayi merged commit e22a63d into main Apr 5, 2024
8 checks passed
kfswain pushed a commit that referenced this pull request Apr 15, 2024
@chiayi @kfswain
Add tests to jupyter notebook in cloudbuild (#524)
c3b17e1 
Test notebooks
@andrewsykim
Copy link
Collaborator

@chiayi can we cherry-pick this into the release-1.1 branch? I think it wouuld be good to exercise the notebook in the release branch going forward

chiayi added a commit that referenced this pull request Apr 22, 2024
@chiayi
Fix cloudbuild error: #524 (comment)
cbf716e
@chiayi chiayi mentioned this pull request Apr 22, 2024
Merged
chiayi added a commit that referenced this pull request Apr 22, 2024
@chiayi
Fix cloudbuild error (#598)
2d3e898 
Fix cloudbuild error: #524 (comment)
chiayi added a commit that referenced this pull request Apr 22, 2024
@chiayi
Fix cloudbuild error: #524 (comment)
786c1b1
chiayi added a commit that referenced this pull request Apr 23, 2024
@chiayi @umeshkumhar
Jupyter notebook cherry pick (#600)
de03310 
* update notebook links to release-1.1 (#501)

* update links to release-1.1

* update links to release-1.1

* uncomment validation and test notebook breakage

* Test notebooks

* Fix cloudbuild error: #524 (comment)

---------

Co-authored-by: Umesh Kumhar <umeshkumhar@google.com>
alpha-amundson pushed a commit that referenced this pull request May 3, 2024
@chiayi @alpha-amundson
Fix cloudbuild error (#598)
4ac122e 
Fix cloudbuild error: #524 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewsykim andrewsykim andrewsykim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@chiayi @andrewsykim